chore: retry oidc discovery #782
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-gw-782.dev.renku.ch |
olevski
force-pushed
the
chore-retry-keycloak-client-init
branch
from
ada9f37 to
08a4a8d
Compare
This makes it so that if other services are not immediately available when the gateway starts, the gateway will not immediately go into
olevski
force-pushed
the
chore-retry-keycloak-client-init
branch
from
08a4a8d to
7baeae8
Compare
leafty
reviewed
Dec 3, 2025
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
Should we also update the helm chart to make use of startup probes?
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes
Member
Author
Yes that should help and I can open a followup PR to this. |
leafty
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #781
/deploy
Adds a retry to the oidc discovery which can fail when reunku is upgraded or is installed for the first time because keycloak takes a while to start up fully.